"Krinkle" posted a comment on MediaWiki.r113616.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113616#c32139
Commit summary for MediaWiki.r113616:
Improved and cleaned up Special:LanguageStats JavaScript to support
collapsing/expanding nested subgroups
Krinkle's comment:
<pre>
+ var $toggler = $( '<span class="groupexpander
collapsed">[</span>' )
+ .append( $( '<a href="#" onclick="return false;"></a>' )
+ .text( mw.msg( 'translate-langstats-expand' ) ) )
+ .append( ']' )
+ .click( function() {
</pre>
Use e.preventDefault() instead of using <code>return false;</code> via
<code>eval()</code>'ed onclick attributes (which is a bit slower and creates a
new function context as well).
<pre>
.click( function ( e ) {
/* code */
e.preventDefault();
</pre>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
