"Reedy" posted a comment on MediaWiki.r113836. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113836#c32174
Commit summary for MediaWiki.r113836: adding two public convenience function wrappers: dropExtensionField and dropExtensionTable Reedy's comment: <blockquote> Soon we will end up with 'dropPgField' (see 'addPgField') and other horror in updater. Shouldn't we aim at providing addField/addTable/dropField/dropTable in relatively-DB independent manner for all databases? I would like to kick all those functions out of PostgresUpdater.php into something proper. </blockquote> If the generic updater is exposing methods like that, you're doing it wrong. These are just utility methods, all defined in the base DatabaseUpdater. Where database specific implementations are needed, they can override the default function dropTable etc, and do it how they want. Which is database independent... _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
