"Krinkle" changed the status of MediaWiki.r113800 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113800#c32180
Old Status: new New Status: ok Commit summary for MediaWiki.r113800: Impliment getModifiedTime for ResourceLoaderLanguageDataModule, using CACHE_ANYTHING, store md5 hash of the grammarforms and compare the hash to see if it is modified. (Code mostly written by Niklas) Ping r112991 Krinkle's comment: Yes, I recognized the logic from GlobalDependency, but without the unnecessary overhead and with the timestamp. This is exactly what I had in mind, very nice :) Perhaps use <code>json_encode</code> though, instead of <code> serialize()</code> (seems a little faster, especially for larger arrays). Marking OK. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
