"Nikerabbit" changed the status of MediaWiki.r113715 to "fixme" and commented
it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113715#c32197
Old Status: new
New Status: fixme
Commit summary for MediaWiki.r113715:
Fix the broken 'add new aggregate group' in r113631
Get the list of groups that can be added to the newly created aggregate group
as response from add action,
populate the groups drop down from that.
Some more js cleanup.
Nikerabbit's comment:
Double space:
+ foreach ( $groups as $group ) {
Still fails with for example a dot in the name.
<pre>
+ $.each(data.aggregategroups.groups,
function( key, value) {
+ $groupSelector.append( $(
'<option>', { value : key } ).text( value ) );
</pre>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
