"Preilly" changed the status of MediaWiki.r113887 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113887
Old status: new New status: ok Commit summary for MediaWiki.r113887: * Abstracted cookie expiration time handling to its own method * Added unit tests for cookie expiration time handling method as well as getUseFormat() * Wanted to add further unit tests around cookie handling, but I cannot get PHPUnit playing nicely with cookies. At first it was causing header issues until prielly suggested disabling output buffereing for the test method, which quieted the errors. However, setcookie() seems to have actual effect in the tests (see commented out tests in this commit). Open to suggestions :) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
