"Reedy" posted a comment on MediaWiki.r113953.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113953#c32227
Commit summary for MediaWiki.r113953:
fix for bug 35245 - add rate limiter and spam filter check
Reedy's comment:
One criticism:
<pre>
+/** Rate limit setting for moodbar **/
255 +$wgMoodBarFeedbackRateLimit = 300;
256 +$wgMoodBarResponseRateLimit = 60;
257 +$wgRateLimits += array(
258 + 'moodbar-feedback' => array( 'user' => array( 1 =>
$wgMoodBarFeedbackRateLimit ) ),
259 + 'moodbar-response' => array( 'user' => array( 1 =>
$wgMoodBarResponseRateLimit ) )
260 + );
</pre>
Changing either $wgMoodBarFeedbackRateLimit or $wgMoodBarResponseRateLimit
after including Moodbar is going to make no difference.
Do we just pass them by reference, or kill them completely, and just use
something like the below to override it if they want to?
<pre>
$wgRateLimits['moodbar-feedback'] = array( 'user' => array( 1 => 5000 ) );
</pre>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
