"Awjrichards" posted a comment on MediaWiki.r113688. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113688#c32257
Commit summary for MediaWiki.r113688: Made wfShellMaintenanceCmd() not totally broken due to excess shell escaping. Awjrichards's comment: Yeesh. '"php" "path/to/script.php"' is a totally legitimate command to run in bash, but I have no idea about other environments (like WIndows). This sounds like a problem (bug?) with proc_open(). Do you see the same behavior with other PHP functions that take $cmd as an argument? I wonder if proc_open() is also escaping $cmd resulting in nasty double escaped-ness. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
