"Bawolff" changed the status of MediaWiki.r114067 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114067#c32265

Old Status: new
New Status: fixme

Commit summary for MediaWiki.r114067:

adding a duration function to language that converts seconds to text

Bawolff's comment:

:$segments[] = wfMsgExt( 'duration-' . $name, 'parsemag', $value );

So if someone does $wgContLang->duration( 10 ); it would return 10 seconds, 
with ''seconds'' in the user language instead of the content language? That 
doesn't seem right. The message should be in the same language as whatever 
language the language object being used represents.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to