"Krinkle" posted a comment on MediaWiki.r114116.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114116#c32297

Commit summary for MediaWiki.r114116:

[jquery.byteLimit] Set vars in return this.each loop
* Set vars in return this.each loop. This is the defacto standard plugin 
structure
  but somehow it slipped through this one (it's a 2 line wrapper, easy to miss).
* Added unit test (which failed before this commit)
* Fixes:
-- (bug 35294) jquery.byteLimit shouldn't set element specific variables 
outside the "return this.each" loop.

Krinkle's comment:

Bug isn't new in 1.19, but in 1.19 there is new code that triggers this bug so 
it is a regression, tagging for backport

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to