[MediaWiki-CodeReview] [MediaWiki r114131]: New comment added, and revision status changed

[MediaWiki Mail]

"Krinkle" changed the status of MediaWiki.r114131 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114131#c32332

Old Status: new
New Status: fixme

Commit summary for MediaWiki.r114131:

Change calls from Xml::namespaceSelector() to Html::namespaceSelector() since 
the former now throws deprecation warnings...

Krinkle's comment:

<pre>
----------
Index: trunk/phase3/includes/specials/SpecialProtectedpages.php
----------
@@ -187,8 +187,19 @@
                return "<span style='white-space: nowrap'>" .
-                       Xml::label( wfMsg( 'namespace' ), 'namespace' ) . 
'&#160;'
-                       . Xml::namespaceSelector( $namespace, '' ) . "</span>";
+               Html::rawElement( 'span', array( 'style' => 
'white-space:nowrap' ),
+                       Html::namespaceSelector(
</pre>

The original opening tag is still there, that doesn't look right:

<pre>
<span style='white-space: nowrap'><span style="white-space:nowrap"><label  .. 
/label>&#160;<select  .../select></span>&#160;

<span style='white-space: nowrap'><label ../label>&#160;<select  .. 
/select></span>
</pre>

Rest looks OK. Marking FIXME for the above.

_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview