"Van de Bugger" posted a comment on MediaWiki.r114096.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114096#c32344
Commit summary for MediaWiki.r114096:
Removed redundant , moved up $wgExtensionCredits and gave descriptions for
classes, internationlization and default values
Van de Bugger's comment:
For you declaration of globals doesn't change anything, but you find this
reason good enough to change the code?
Roughly, I have a function like this:
function LoadExtension( $name ) {
...
require_once( ".../$name/$name.php" );
...
}
This does work only if "$name.php" declares all used globals before use them.
So, please, put global declarators back.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
