"Bawolff" posted a comment on MediaWiki.r114117.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114117#c32349
Commit summary for MediaWiki.r114117:
* (bug 35303) Make proxy and DNS blacklist blocking work again
Bawolff's comment:
Thanks for fixing this.
The block notice the user sees for this is a little confusing. However its
quite possible it was always like that. For reference the user sees (assuming
its localhost that was blocked, as was the case on my test wiki. Note: the
DNSBL in the text actually links to [[user:DNSBL]]).
<pre style="white-space:pre-wrap">
You do not have permission to edit this page, for the following reason:
Your username or IP address has been blocked.
The block was made by DNSBL. The reason given is Your IP address is listed as
an open proxy in the DNSBL used by Test..
* Start of block: 15:01, 19 March 2012
* Expiry of block: 15:01, 19 March 2012
* Intended blockee: 0:0:0:0:0:0:0:1
You can contact DNSBL or another administrator to discuss the block. You cannot
use the 'e-mail this user' feature unless a valid e-mail address is specified
in your account preferences and you have not been blocked from using it. Your
current IP address is ::1, and the block ID is #. Please include all above
details in any queries you make.
</pre>
Perhaps having a FakeBlock object that various classes can detect and do
something more intelligent when displaying the error message would be a good
approach.
Should probably also have a regression test. (DNS blacklist would be difficult,
but checking against $wgProxyList should be straightforward). I'll try to get
around to adding a regression test for that at some point or another.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
