"QChris" posted a comment on MediaWiki.r114126. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114126#c32353
Commit summary for MediaWiki.r114126: Sanitizing already existing use of PHP's assert QChris's comment: Yes, absolutely :D HipHop does support assert. However, as HipHop is taylored for production servers, it comes with different defaults: Assertion checking (and warning) is turned off per default, as it should be for production servers. Everything works nicely on the HipHop Interpreter. But I just realized, that when ''not'' interpreting the file ''and'' turning on assertion checking ''and'' passing as the condition as string ''and'' using the vanilla distribution, the executable chokes. So, to be more defensive, I reverted Preprocessor_HipHop.hphp in r114217 to avoid that the assert gets in the way. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
