"Jeroen De Dauw" posted a comment on MediaWiki.r113913.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113913#c32356

Commit summary for MediaWiki.r113913:

Restored backward-compatibility for MW 1.17 (?), improved display of "more than 
one form" warning

Jeroen De Dauw's comment:

Ahh, that looks like an evil compat check :)

Why not do something like this, and then do $out = $this->getOutput()?

http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/Push/specials/Push_Body.php?revision=113155&view=markup#l353

And you can use the same stuff to get rid of a bunch of other globals as well :)

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to