"Kaldari" changed the status of MediaWiki.r114344 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114344#c32421

Old Status: new
New Status: fixme

Commit summary for MediaWiki.r114344:

Resolve issues with r109666: mixing getters and setters in the same function is 
confusing, so split it in 2. Also removes isset() to check for null

Kaldari's comment:

The comments for setCheckoutResult() says that it returns an array, but it 
actually returns nothing. It should either be set to return true or the @return 
comment should be removed.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to