"Dantman" posted a comment on MediaWiki.r114354. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114354#c32424
Commit summary for MediaWiki.r114354: * Removed the $method parameters from MWCryptRand. Apparently Dantman didn't know about our awesome debug traceback functions like wfGetAllCallers(). The weird optional-middle-parameter calling convention thankfully disappears as a consequence. * Reduced the amount of debug log noise slightly, removing a few redundant messages. Dantman's comment: Debug messages telling you where the random data came from so you know what's not working was sort of intentional. I suppose later we could try storing that in a var and formatting a single debug message. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
