"Xqt" changed the status of pywikipedia.r10036 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10036#c32460

Old Status: new
New Status: fixme

Commit summary for pywikipedia.r10036:

New -overwrite=[yes|no] option for djvutext

Patch by Lars Aronsson <[email protected]>
Reference: pywikipediabot-Patches-3502676

Xqt's comment:

I am unhappy with this implementation. <code>-ask -override:<yeah|never></code> 
does not ask as one might expect but <code>-override</code> without 
specification does not override anything. Capital letters should also be valid 
arguments. btw: line 206 is obsolete; that value is initially given in line 194.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to