"Khorn (WMF)" posted a comment on Wikimedia.r1458. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1458#c32489
Commit summary for Wikimedia.r1458: followup r1346, r1454 Does some suddenly necessary transaction id staging and parsing and checking and crud, in the contribution add function. This needs to change according to the inline TODO as soon as we both get GC recurring out the door and upgrade civi. Khorn (WMF)'s comment: Nope: You did pass in a malformed transaction ID. If there are three parts after you explode on spaces, they should be: <ul> <li>Uppercased gateway</li> <li>Gateway order id</li> <li>Timestamp</li> </ul> If you want to keep this as a fixme, it would be for the sake of clarity in the error messaging. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
