"Khorn (WMF)" posted a comment on Wikimedia.r1500.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1500#c32491

Commit summary for Wikimedia.r1500:

Added dependency on thank_you module to qc

Khorn (WMF)'s comment:

Actually, any module that is called via hook does not constitute a dependency. 
That's sort of the whole point of having hooks.
A dependency only exists if the current module cannot function without the 
other. In other words, if the module doesn't crash and burn without the other 
module being installed, it's not dependent.
Reverting.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to