"Khorn (WMF)" changed the status of Wikimedia.r1476 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1476#c32493
Old Status: new New Status: fixme Commit summary for Wikimedia.r1476: Enabling _queue2civicrm_contribution_recur_insert(). See r1475. Khorn (WMF)'s comment: This is pretty nitpicky, but I promise it will definitely be an issue at least once if we don't fix it: <br> This whole block of code should happen before the "Tag Contact for Review" block just above it, so it's the first thing we do after we check to see that the contribution was made. Otherwise, if there is something wrong with the civi config, the first contribution will get made, but it will explode before the subscription gets inserted. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
