"Khorn (WMF)" posted a comment on Wikimedia.r1476.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1476#c32499

Commit summary for Wikimedia.r1476:

Enabling _queue2civicrm_contribution_recur_insert(). See r1475.

Khorn (WMF)'s comment:

Also, I see that not every false return path in 
_queue2civicrm_contribution_recur_insert inserts a drush error. This needs to 
happen so the controlling function knows what to do on a failure in there. On a 
related note, all the drush errors you set need to have an entry in the 
severity array defined in _queue2civicrm_get_top_new_drush_error, or the 
controlling function won't know what to do with it anyway. 

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to