"Bsitu" posted a comment on MediaWiki.r114047.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114047#c32506

Commit summary for MediaWiki.r114047:

fix for bug33214 - catch all exceptions in api execute and provides necessary 
parameters required by the custom printer

Bsitu's comment:

Thank you for the comment, I agree with what you said, that means the custom 
printer needs to be altered to some other printers on error since the custom 
printer requires some additional parameters which exception does not provide, 
that doesn't seem to be an easy fix to me as the API can be executed in a mode 
with exception not being caught and there looks quite a lot of dependencies in 
ApiMain.php,  However, there may be an easy fix to this which I don't see so I 
am open to any feedbacks, :) 

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to