On Sat, Mar 17, 2012 at 9:08 AM, Krinkle <[email protected]> wrote: > Feel free to discuss it either on the talk page[1] or here on wikitech-l > and the workflow is also posted to this wiki page: > https://www.mediawiki.org/wiki/Continuous_integration/Workflow > so feel free to edit it as you would any other wiki page.
Left a note on talk to clarify that the tests run before any human review gets involved. :) I'm noticing that the current GIT-Fetching job in Jenkins already is running builds against unmerged changesets, so I'm assuming the workflow page is just in error about builds only being run if changes are merged? This video BTW has a nice explanation of a working git/gerrit/jenkins integration. http://vimeo.com/20084957 Notice the Jenkins user posting a "build started" comment the moment a change goes into Gerrit, and then adding a +1 on test or a -1 on failure (although that should arguably be a -2). -- Erik Möller VP of Engineering and Product Development, Wikimedia Foundation Support Free Knowledge: https://wikimediafoundation.org/wiki/Donate _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
