"Khorn (WMF)" posted a comment on Wikimedia.r1504.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1504#c32542

Commit summary for Wikimedia.r1504:

Added validation for the process flag. See r1501.

Khorn (WMF)'s comment:

Yeah: I see in r1382, process is assigned a default way down in what is now 
recurring_globalcollect_process_get_query_options. I'm kind of wondering why 
it's all the way down there, instead of out in the drush file, as nothing else 
can run this code and we have no plans for anything to be able to do so in the 
future. 
<br>But, no: As of right now, this is not a required value and will default to 
next_sched_contribution. 

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to