"Khorn (WMF)" posted a comment on Wikimedia.r1529.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1529#c32546

Commit summary for Wikimedia.r1529:

Made batch_max a setting. See r1503.

Khorn (WMF)'s comment:

Yeah: Watchdog errors get displayed in realtime, and the drush error that 
killed the process is displayed on process exit. If a process-killing error is 
the only thing that happens, it would look like two in a row from the command 
line. If more happened, it would be totally unclear which watchdog message went 
with the thing that caused execution to unwind and halt itself.
<br><br>However, even in instances where a process-killing error is the only 
thing that happens, both are necessary: watchdog to get the log entry somewhere 
we can see it from drupal, and the drush error so the main controller loop 
knows what do to, and Jenkins knows there was an explosion and can e-mail 
people about it. 
<br><br>In other words, don't worry about seeing the error on the command line 
twice. The both serve a purpose, and this behavior has been with us for pretty 
much the whole time. 

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to