"Valhallasw" posted a comment on pywikipedia.r10063.
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10063#c32587

Commit summary for pywikipedia.r10063:

featured.py need to identify the "#" sortkey (bug #3511935)

Valhallasw's comment:

+    for article in cat.articles(endsort=hide):
        68      +        yield article
        69      +    if hide:
        70      +        for article in 
cat.articles(startFrom=chr(ord(hide)+1)):
        71      +            yield article

I'm (a) not quite sure how this is supposed to work and (b) not sure if 
"startFrom=chr(ord(hide)+1)" is a good way to start at the 'next' letter. It 
will break when it's non-ascii, for one thing. (chr only works for the 0..255 
range).

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to