On Sun, Apr 8, 2012 at 5:44 AM, Daniel Friesen <[email protected]>wrote:
> -- tl;dr start -- > We're using gerrit now. And as we use it we all keep running into issues > stemming fundamentally from how gerrit is designed. > > I had an irc discussion with Roan[1] awhile ago tossing around ideas on > how we would write a review system for git if we wrote one from scratch. > Based on a number of things I noted there I started a draft of how such a > review system would work: > https://www.mediawiki.org/**wiki/User:Dantman/**CodeReviewSystem<https://www.mediawiki.org/wiki/User:Dantman/CodeReviewSystem> > I probably haven't written down nearly as much detail on that page as I've > thought out for the actual system. > > My views have evolved a bit on this, and I now believe a much more feasible thing to do would be to use an existing project (gitosis or gitolite is probably best) for the repository/permissions management, and build a review system on top of that. As for the rest of the notes, I'll have to read those more thoroughly when I'm more capable of deep thought (i.e. not battling a cold). > This is a long term project. It's definitely going to take awhile before > it's ready to manage MediaWiki. However we're using git now, so this > project doesn't have as much pressure. Since git is distributed things can > easily coexist; We can put this up on labs before it's ready for primetime. > When it's somewhat ready we can opt-in to trying it on less important > repos. And even when we switch it will be possible to do so in a way such > that gerrit and the review system co-exist until all changesets in gerrit > have finished being reviewed. > -- tl;dr end -- > > In one of my one-day bouts of coding I started trying to implement the > system: > https://github.com/dantman/**gareth <https://github.com/dantman/gareth> > > Love the name :) Will look at this once I feel better. > I welcome anyone who feels like turning the short-cuts into a properly > written system. And anyone who feels like turning MediaWiki's code into a > framework. Or anyone who feels that a framework they know fits best and > wants to make the review system use it (Though no file layout controlling > MVC frameworks, please). > > I would love to help you with this once I have time to do so. Right now I'm still getting settled after moving between countries, so essentially I have no free time. And I've been feeling sickly since Friday. Roan _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
