"Khorn (WMF)" changed the status of Wikimedia.r1548 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1548#c32657
Old Status: new New Status: fixme Commit summary for Wikimedia.r1548: Replacing crg with recurring_globalcollect. See r1529. Khorn (WMF)'s comment: Tiny, tiny fixme: <br> <pre> /** * @var string $watchdog_type The watchdog error type */ - $watchdog_type = 'crg'; + $watchdog_type = 'rg'; </pre> <br> The only thing this var is used for is the first param in a watchdog call, and you changed all the others from 'crg' to 'recurring_globalcollect'. Is this supposed to be different than all the other ones? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
