"Khorn (WMF)" changed the status of Wikimedia.r1570 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1570#c32660
Old Status: new New Status: ok Commit summary for Wikimedia.r1570: Failed payments should be marked with a failed status. Khorn (WMF)'s comment: It might be cool to actually establish that status array in a function which returns the integer of the status when you pass in the string. That way, what you're actually setting is crystal clear from every local place you have to set a status, and way more trivial to debug later. <br>...but that's clearly not a blocking issue. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
