"Khorn (WMF)" changed the status of Wikimedia.r1638 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1638#c32733
Old Status: new New Status: fixme Commit summary for Wikimedia.r1638: Added setting for recurring_globalcollect_failures_before_cancellation. Added new drush error label RG_SETTINGS for problems with recurring_globalcollect settings. Khorn (WMF)'s comment: Even though this problem crept in before this point (probably r1377?): This function should basically control how the script will behave for different defined drush errors. Some (system-wide misconfigurations, GC exploding, etc) should halt the entire process for now, and some should only mark some payments as being faulty and keep going. This function should have the ability to throw appropriate exceptions up the call stack to achieve the desired effect for each possible error type. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
