"Tim Starling" posted a comment on MediaWiki.r114923. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114923#c32744
Commit summary for MediaWiki.r114923: noclock mode missed some variables definition Tim Starling's comment: Declaring timer_settime(), timer_delete() and timer_create() appears to be unnecessary and potentially harmful. If anything refers to those when LUASANDBOX_NO_CLOCK is set, declaring them will just defer the error until link. Also, if anything refers to luasandbox_timeout_message and it's an uninitialised array, a crash may result. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
