"Catrope" changed the status of MediaWiki.r115026 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115026#c32746
Old Status: new
New Status: fixme
Commit summary for MediaWiki.r115026:
Made switchAllMediaWikis require a .dblist file. It will now only switch wikis
in the specified file.
Catrope's comment:
<pre>
+ if ( isset( $dbList[$dbName] ) // wiki is in the .dblist file
+ && ( $version === $oldVersion || $oldVersion === 'all' ) )
+ {
+ $newWikiVersionsData .= MWWikiversions::lineFromRow(
+ array( $dbName, $newVersion, $extVersion, $comment )
+ );
+ ++$count;
+ }
</pre>
If the wiki doesn't match the criteria, this should output the original row
unchanged. Otherwise it doesn't produce a full wikiversions.dat file and there
will be missing wikis.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
