"Valhallasw" posted a comment on pywikipedia.r10132.
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10132#c32755

Commit summary for pywikipedia.r10132:

First step for twn support for userinterface. This supports input questions by 
replacing pywikibot.input() by i18n.input(). Notify the parameters.

Valhallasw's comment:

And something else:

+        userinterface_lang = 'de'
441     +        default is mylang setting


I think it makes more sense to default to the locale:

valhallasw@dorthonion:~/src/pywikipedia/trunk$ python
Python 2.7.1+ (r271:86832, Apr 11 2011, 18:05:24)
[GCC 4.5.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import locale
>>> locale.getdefaultlocale()
('en_GB', 'UTF8')

C:\Users\valhallasw>python
Python 2.7.2 (default, Jun 12 2011, 15:08:59) [MSC v.1500 32 bit (Intel)] on win
32
Type "help", "copyright", "credits" or "license" for more information.
>>> import locale
>>> locale.getdefaultlocale()
('nl_NL', 'cp1252')


note that the first can also be 'C', but I think we fall back to english by 
default anyway.



_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to