"Valhallasw" posted a comment on pywikipedia.r10089.
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10089#c32760

Commit summary for pywikipedia.r10089:

Enable ignore list for repeated runs + some error handling.

Valhallasw's comment:

The issue is that the code to filter a list of pages using an ignore list 
*already exists* (pagegenerators.FilteredGenerator). Instead of using that one, 
this code implements it's own version (=code duplication) but with slightly 
different behaviour (= bug!).

In addition, it is much nicer to have filtering where it belongs (in the 
pagegenerator, and not in the bot code).

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to