"Khorn (WMF)" posted a comment on Wikimedia.r1718.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1718#c32767

Commit summary for Wikimedia.r1718:

Adding code to offline2civicrm that adds checks to a group for review

Khorn (WMF)'s comment:

The only thing I can see here that I might possibly change, is returning early 
for everything that isn't a check. As that's just a readability (and 
lightning-fast debugging) thing, it's okay to deploy. 

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to