"Valhallasw" posted a comment on pywikipedia.r10152.
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10152#c32792

Commit summary for pywikipedia.r10152:

Adding categories sort for Persian Wikipedia

Valhallasw's comment:

First of all: you're not the first one to encounter this problem: 
http://en.wikipedia.org/wiki/Collation - and there already exist libraries to 
do this. Use them.

Secondly, your code is incomprehensible to me. You seem to be converting the 
string to a string of digits, doing some string mangling and ending up with a 
magic result - with extra hard-coded 'category' naming. But how it works, and 
how anyone except you could debug it...?

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to