Hi, I have recently made some changes to Proofread extension[1]. There are more in the review queue[2]. This extension needs refactoring and I have some free time to do it.
I prefer making small changes, so it is easy to review and test them. However due to not clearly determined order of merging changes I have no idea what should I choose as my baseline. I prefer to avoid solving merge conflicts with myself. This usually happens when changes got reviewed and merged in for example reverse order. It is clearly a waste of time. I know gerrit can use dependencies, so I can make a chain of dependant changes: c1 <- c2 <- c3 <- c4. However if c2 and c3 got a positive review and c1 needs some rework, c2 and c3 need to be reviewed again after I submit c1. Sometimes another, unrelated change may be merged, so the whole chain needs to be rebased against master. The most ideal approach would be to review changes as soon as they are submitted, but I am well aware, that there are not enough people to do the review. Any thoughts? [1] https://gerrit.wikimedia.org/r/#/q/status:closed+project:mediawiki/extensions/ProofreadPage,n,z [2] https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/ProofreadPage,n,z -- Thanks, Beau _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
