I put a note in the documentation reflecting what you said. See the text: *Note:* *In regards to which Change-Id you want to use...*
On Thu, May 10, 2012 at 12:37 PM, Roan Kattouw <[email protected]>wrote: > On Thu, May 10, 2012 at 12:19 PM, Jeremy Postlethwaite > <[email protected]> wrote: > > Thanks Roan, > > > > I updated the documentation. > > > > Does it matter which Change-Id you pick of your commits? > > - Is it best to pick the last over the first or vice-versa? > > > If they're new commits, it doesn't matter. However, if you're > squashing a commit into an existing commit (one that's already in > Gerrit), you need to pick the Change-Id that belongs to the one you > meant to submit a new patchset for (the 'surviving' commit). > > Roan > > _______________________________________________ > Wikitech-l mailing list > [email protected] > https://lists.wikimedia.org/mailman/listinfo/wikitech-l > -- Jeremy Postlethwaite [email protected] 415-839-6885 x6790 Backend Software Developer Wikimedia Foundation <http://wikimediafoundation.org/> _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
