"Platonides" posted a comment on MediaWiki.r100286. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100286#c32808
Commit summary for MediaWiki.r100286: * Tweaked Revision class to handle loading the current user name instead of rev_user_text. It still falls back to rev_user_text when building objects from DB rows for b/c. * Moved JOIN conds to fetchFromConds() as that's where the tables are specified. This lets us avoid the same page_id=rev_page join conds plastered all over the code. Also, we can't mix WHERE and JOIN style join conds. * Removed duplication in fetchFromConds() by using selectPageFields(). * Removed duplicate rev_parent_id field from contribs SELECT. Yo make use of these changes, Pagers and lists still need to be updated to use Revision::selectUserFields() and join on the user table. Platonides's comment: What's the point of this? For instance you're now joining two tables in action=history when you have all the needed data in a single one. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
