"Krinkle" posted a comment on MediaWiki.r115429.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115429#c32823

Commit summary for MediaWiki.r115429:

style of code

Krinkle's comment:

Nearly every line, actually.

I think the problem is that it appears you start counting the extra tab from 
roughly where the contents of the previous line ends (rather than where the 
indention of the previous line ends).

<pre>
+                               $foo = $bar->getOption(
+                               →       →       →       →       'Test',
+                               →       →       →       →       $example
+                               →       →       );
+                               $foo = $bar->baz->quux->getOption(
+                               →       →       →       →       →       'Test',
+                               →       →       →       →       →       $example
+                               →       →       );
</pre>

vs.
<pre>
+                               $foo = $bar->getOption(
+                               →       'Test',
+                               →       $example
+                               );
+                               $foo = $bar->baz->quux->getOption(
+                               →       'Test',
+                               →       $example
+                               );
</pre>

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to