On Mon, Jul 2, 2012 at 9:59 PM, Rob Lanphier <[email protected]> wrote: > On Mon, Jul 2, 2012 at 9:19 PM, Diederik van Liere <[email protected]> > wrote: >> I became curious with these statements regarding self-review >> (committer==reviewer) and so I ran a couple >> of queries against the gerrit database to see how often this occurs: >> >> 1) For the puppet repo, 84.1% of the commits is self-reviewed. > > Yeah, I don't think Ops is proud of this, but from my understanding, > it's very difficult to develop for puppet without committing and > seeing what happens. It's possible, but it's definitely not as > productive.
I would agree with Ryan and say that it's not that we're not proud of this, it's that we have a different workflow. There's a lot of repetitive style work in our job (putting new servers in puppet and dhcp files, for example). These minor commits don't need any major review. Major changes can be tested in labs, usually have someone else check them out, and for many changes the worst breakage that happens is that puppet stops running(instead of a dead site). Leslie -- Leslie Carr Wikimedia Foundation AS 14907, 43821 http://as14907.peeringdb.com/ _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
