Hey, You mean site_config? > You're suggesting the interwiki system should look for a site by > site_local_key, when it finds one parse out the site_config, check if it's > disabled and if so ignore the fact it found a site with that local key? > Instead of just not having a site_local_key for that row in the first place? >
No. Since the interwiki system is not specific to any type of site, this approach would be making it needlessly hard. The site_link_inline field determines if the site should be usable as interwiki link, as you can see in the patchset: -- If the site should be linkable inline as an "interwiki link" using -- [[site_local_key:pageTitle]]. site_link_inline bool NOT NULL, So queries would be _very_ simple. > So data duplication simply because one wiki needs a second local name will mean that one url now has two different global ids this sounds precisely like something that is going to get in the way of the whole reason you wanted this rewrite. * It does not get in our way at all, and is completely disjunct from why we want the rewrite * It's currently done like this * The changes we do need and are proposing to make will make such a rewrite at a later point easier then it is now > Doing it this way frees us from creating any restrictions on whatever source we get sites from that we shouldn't be placing on them. * We don't need this for Wikidata * It's a new feature that might or might not be nice to have that currently does not exist * The changes we do need and are proposing to make will make such a rewrite at a later point easier then it is now > So you might as well drop the 3 url related columns and just use the data blob that you already have. I don't see what this would gain us at all. It's just make things more complicated. > The $1 pattern may not even work for some sites. * We don't need this for Wikidata * It's a new feature that might or might not be nice to have that currently does not exist * The changes we do need and are proposing to make will make such a rewrite at a later point easier then it is now And in fact we are making this more flexible by having the type system. The MediaWiki site type could for instance be able to form both "nice" urls and index.php ones. Or a gerrit type could have the logic to distinguish between the gerrit commit number and a sha1 hash. Cheers -- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. -- _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
