Le 25/10/12 07:07, Tyler Romeo a écrit :
> So recently https://gerrit.wikimedia.org/r/15746 was merged. It implements
> a pretty timestamp function. Yet it was somehow completely ignored that we
> actually have an MWTimestamp class made specifically for timestamp objects
> in MediaWiki.

Hello,


There are a few issues with it such as:
 - methods having optional parameters before required one
 - we have to pass a User object
 - the whole prettyTimestamp() is very confusing

Note that change 15746 has been written before the introduction of
MWTimestamp.

I would prefer we revert that change and improve it, possibly using PHP
DateInterval and definitely with MWTimestamp.

cheers,

-- 
Antoine "hashar" Musso


_______________________________________________
Wikitech-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Reply via email to