On Wed, Dec 12, 2012 at 3:09 AM, Ryan Kaldari <[email protected]> wrote: > I found a solution to the problem: > If a gerrit administrator declares the mimetypes of the files to be safe > they will be displayed in-browser rather than downloaded as zip files: > https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#_a_id_mimetype_a_section_mimetype > > Could someone edit the gerrit.config file to declare php, javascript, and > css files as 'safe'? >
That doesn't quite work the way you're thinking--it's for us to define mimetypes that Gerrit should show diffs of (rather than a zip download of the file). All text- based filetypes are already shown by the browser as diffs, but most binary filetypes aren't shown on diff. Images originally suffered this problem, but we fixed it[0]. There's not a config switch for what the OP is asking for--but feel free to file a bug upstream[1] :) -Chad [0] https://bugzilla.wikimedia.org/show_bug.cgi?id=36852 [1] https://code.google.com/p/gerrit/issues/list _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
