Ah, thanks, that explains it.

2013/1/9 Brad Jorsch <[email protected]>

> 2013/1/9 Denny Vrandečić <[email protected]>:
> > I am mildly surprised by Jenkins giving a +1 Code Review (not
> Verification)
> > here.
> >
> > <https://gerrit.wikimedia.org/r/#/c/33505/>
> >
> > Just wondering if there is maybe a setup issue.
>
> Note that was on December 17. I don't remember the exact dates, but
> for a short time during the transition from "Jenkins runs unit tests
> on every submission" to "Jenkins runs only lint tests for submissions
> from untrusted people" it was configured to give CR+1 for linting and
> V+1 for unit tests.
>
> _______________________________________________
> Wikitech-l mailing list
> [email protected]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l




-- 
Project director Wikidata
Wikimedia Deutschland e.V. | Obentrautstr. 72 | 10963 Berlin
Tel. +49-30-219 158 26-0 | http://wikimedia.de

Wikimedia Deutschland - Gesellschaft zur Förderung Freien Wissens e.V.
Eingetragen im Vereinsregister des Amtsgerichts Berlin-Charlottenburg unter
der Nummer 23855 B. Als gemeinnützig anerkannt durch das Finanzamt für
Körperschaften I Berlin, Steuernummer 27/681/51985.
_______________________________________________
Wikitech-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Reply via email to