Le 18/02/13 03:22, Moritz Schubotz wrote: > in the next version of the code review system, a way to classify the > type of change would be great. Maybe the trac-system would a good > inspiration. i.e. a critical bug may be more important to review soon > than a new feature.
Hello, In our homegrown system, we used to be able to add keywords on changes. That feature is more or less tracked in bugzilla: Establish suitable short-term replacement for important code review tags https://bugzilla.wikimedia.org/show_bug.cgi?id=38239 We mostly use Gerrit has a way to attach an identifier to a change. The prioritization is handled at the bug level and hence using the fields in Bugzilla. Note that some critical bugs might be less important than a new feature :-] > Furthermore running stylize.php remotely might be helpful to avoid > that people waste their time with those formal aspects. If I remember correctly, stylize.php is mostly handling whitespaces and comments which are neither really important. We can not really alter the submitted patchset (that will change the commit sha1) which left us with running it in Jenkins after the change as merged. I believe most of stylize.php reporting capabilities are already in our PHP_CodeSniffer standard. -- Antoine "hashar" Musso _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
