On Mon, May 13, 2013 at 2:21 AM, Daniel Friesen
<[email protected]>wrote:

> * Your RL module should have a remote path in addition to a local one, it's
>   also proper to declare the media type for your css. You should also drop
>   the `@CHARSET "UTF-8"`.
> * The wfMessage calls should probably be $this->msg instead.
> * i18n messages are generally used for opening and closing parenthesis
> iirc.
> * You want $this->getLanguage() not $wgLang.
> * Don't mess with the error_reporting setting in extension code.
>

Thanks a lot Daniel! Much appreciated.

I also noticed I should go through the styleguide to make sure I follow the
proper conventions (spaces, loops, etc). I'm going to go over it all in the
next couple of days.

One quick question -- I'm not sure I understand your first comment. What do
you mean RL module? a remote path where? do you mean in the
"$wgExtensionCredits[ 'specialpage' ][]" array?

Thanks again!

Moriel

-- 
No trees were harmed in the creation of this post.
But billions of electrons, photons, and electromagnetic waves were terribly
inconvenienced during its transmission!
_______________________________________________
Wikitech-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Reply via email to