Ok, I have landed: * https://gerrit.wikimedia.org/r/#/c/78669 (core LESS support) * https://gerrit.wikimedia.org/r/#/c/85143/ (.background-image embedding helper function)
Any further tweaks needed on the core support should be done as separate patches rather than additional patchsets on those, as they are merged. :) Next steps -- review and merge when ready on usages of less: * https://gerrit.wikimedia.org/r/#/c/84139/ - update for MobileFrontend * https://gerrit.wikimedia.org/r/#/c/85161/ - draft core tweak -- brion On Sun, Sep 22, 2013 at 10:57 AM, Ori Livneh <o...@wikimedia.org> wrote: > On Sat, Sep 21, 2013 at 10:50 AM, Brion Vibber <bvib...@wikimedia.org > >wrote: > > > Ok, we've had another round of review and updates, and it sounds like > > people are pretty content with the functionality and the conventions > we're > > coming up with around LESS usage; and I don't hear many strong > objections. > > > > If there's no last-minute surprises from anybody, I'll drop the +2 hammer > > on the core support <https://gerrit.wikimedia.org/r/#/c/78669/> later > > today, and folks can start using it. > > > > There were a couple of suggestions to expand the inline documentation for > the configuration vars, which I did. Unless there are objections, I > recommend merging it in tandem with < > https://gerrit.wikimedia.org/r/#/c/85143/>. > > My sincere thanks to all reviewers. > _______________________________________________ > Wikitech-l mailing list > Wikitech-l@lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/wikitech-l > _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
