On Tue, Oct 8, 2013 at 12:15 AM, Tim Starling <[email protected]> wrote: > On 08/10/13 14:40, Erik Bernhardson wrote: >> A reviewer should be able to >> know if the error conditions are properly handled by looking at the new >> code, not by looking up all the function calls to see what they can >> possibly return. > > This is why the recommended pattern for Status objects is to return a > Status object unconditionally
Can we add an example of that usage to the status object with a note not to follow the "return this in case of error" pattern that you might see elsewhere in the code? It might even be worth a bit of refactoring to get rid of the old pattern or people will still keep finding it and copying it. _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
