I think a better way to go is to add a hook point in RecentChange::checkIPaddress()... I don't like mixing more session-related stuff into User like a getUserIP method.
-- brion On Oct 27, 2013 2:46 PM, "Marcin Cieslak" <[email protected]> wrote: > >> Brion Vibber <[email protected]> wrote: > > Generally I would not recommend subclassing User; while you can certainly > > create such a subclass it will have limited utility as you can't really > > control how they get created easily. > > > > Like the rest of MediaWiki, the User class is intended to be customized > > through extension hooks... What sort of behavior customization are you > > thinking of doing? > > Some example: > > https://gerrit.wikimedia.org/r/#/c/92252/ > > needs https://gerrit.wikimedia.org/r/#/c/92179/ in core, > that gives some method to override. > > Surprisinly, it even works (rc_ip will be set to "" on > AbuseFilter blocks). > > //Saper > > > _______________________________________________ > Wikitech-l mailing list > [email protected] > https://lists.wikimedia.org/mailman/listinfo/wikitech-l _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
